feat(rcon): allow administrator-defined endpoints

apps/web/src/lib/rcon-validation.test.ts

@@ -1,32 +1,36 @@
 import { describe, expect, it } from "vitest";
 import { sanitizeRconOutput, validateRconCommand, validateRconConnection } from "./rcon-validation";
 
-const allowed = "season4.somc.svc.cluster.local:25575,creative.somc.svc.cluster.local:25576";
-
 describe("RCON validation", () => {
-  it("normalizes an allowlisted internal endpoint", () => {
+  it("normalizes any valid DNS hostname and port without deployment configuration", () => {
     expect(validateRconConnection({
       name: " Season 4 ",
       host: "SEASON4.SOMC.SVC.CLUSTER.LOCAL",
       port: "25575",
       password: "correct horse battery staple",
-    }, { allowedEndpoints: allowed, passwordRequired: true })).toEqual({
+    }, { passwordRequired: true })).toEqual({
       name: "Season 4",
       host: "season4.somc.svc.cluster.local",
       port: 25575,
       password: "correct horse battery staple",
     });
+
+    expect(validateRconConnection({
+      name: "Creative",
+      host: "creative.example.net",
+      port: "43210",
+      password: "secret",
+    }, { passwordRequired: true })).toEqual({
+      name: "Creative",
+      host: "creative.example.net",
+      port: 43210,
+      password: "secret",
+    });
   });
 
-  it("rejects unlisted hosts, ports, IP literals, and suffix confusion", () => {
-    for (const [host, port] of [
-      ["postgres.somc.svc.cluster.local", "5432"],
-      ["season4.somc.svc.cluster.local", "5432"],
-      ["season4.somc.svc.cluster.local.attacker.example", "25575"],
-      ["10.0.0.1", "25575"],
-    ]) {
-      expect(validateRconConnection({ name: "Server", host, port, password: "secret" }, {
-        allowedEndpoints: allowed,
+  it("rejects IP literals and malformed DNS hostnames", () => {
+    for (const host of ["10.0.0.1", "2001:db8::1", "season4.", "-season4.example", "season4..example"]) {
+      expect(validateRconConnection({ name: "Server", host, port: "25575", password: "secret" }, {
         passwordRequired: true,
       })).toBeNull();
     }
@@ -34,11 +38,9 @@ describe("RCON validation", () => {
 
   it("allows a blank replacement password only while editing", () => {
     expect(validateRconConnection({ name: "Server", host: "season4.somc.svc.cluster.local", port: "25575", password: "" }, {
-      allowedEndpoints: allowed,
       passwordRequired: false,
     })?.password).toBeNull();
     expect(validateRconConnection({ name: "Server", host: "season4.somc.svc.cluster.local", port: "25575", password: "" }, {
-      allowedEndpoints: allowed,
       passwordRequired: true,
     })).toBeNull();
   });