feat: add per-player movement and block metrics

README.md

@@ -84,6 +84,7 @@ Some metrics depend on server implementations (TPS/MSPT, player ping, tile entit
 | --- | --- | --- | --- |
 | spigot_chat_messages_total | counter | none | Total chat messages sent |
 | spigot_player_movements_total | counter | none | Total player movement events |
+| spigot_player_movements_by_player_total | counter | player | Player movements by player |
 | spigot_players_joined_total | counter | none | Total player joins |
 | spigot_players_quit_total | counter | none | Total player quits |
 | spigot_chunk_loads_total | counter | none | Total chunk load events |
@@ -92,6 +93,10 @@ Some metrics depend on server implementations (TPS/MSPT, player ping, tile entit
 | spigot_plugin_enable_total | counter | none | Total plugin enable events |
 | spigot_plugin_disable_total | counter | none | Total plugin disable events |
 | spigot_blocks_broken_total | counter | material | Blocks broken by material |
+| spigot_blocks_broken_by_player_total | counter | player,material | Blocks broken by player and material |
+| spigot_blocks_placed_total | counter | material | Blocks placed by material |
+| spigot_items_crafted_total | counter | material | Items crafted by material |
+| spigot_entities_killed_total | counter | entity,killer | Entities killed by player |
 | spigot_player_deaths_total | counter | cause | Player deaths by cause |
 | spigot_player_logins_failed_total | counter | reason | Failed player logins by reason |
 | spigot_commands_blocked_total | counter | command | Blocked commands by name |

src/main/java/com/prometheus/spigot/PrometheusSpigotPlugin.java

@@ -3,7 +3,7 @@ package com.prometheus.spigot;
 import com.prometheus.spigot.http.MetricsHttpHandler;
 import com.prometheus.spigot.listeners.BlockBreakListener;
 import com.prometheus.spigot.listeners.BlockPlaceListener;
-import com.prometheus.spigot.listeners.ChatMessageListener;
+import com.prometheus.spigot.listeners.ChatListener;
 import com.prometheus.spigot.listeners.ChunkListener;
 import com.prometheus.spigot.listeners.CommandListener;
 import com.prometheus.spigot.listeners.ConnectionListener;
@@ -76,7 +76,7 @@ public final class PrometheusSpigotPlugin extends JavaPlugin {
         pluginManager.registerEvents(new BlockBreakListener(metricsRegistry), this);
         pluginManager.registerEvents(new BlockPlaceListener(metricsRegistry), this);
         pluginManager.registerEvents(new DeathListener(metricsRegistry), this);
-        pluginManager.registerEvents(new ChatMessageListener(metricsRegistry), this);
+        pluginManager.registerEvents(new ChatListener(metricsRegistry), this);
         pluginManager.registerEvents(new MoveListener(metricsRegistry, countBlockMovementOnly), this);
         pluginManager.registerEvents(new ConnectionListener(metricsRegistry), this);
         pluginManager.registerEvents(new CommandListener(metricsRegistry), this);

src/main/java/com/prometheus/spigot/listeners/BlockBreakListener.java

@@ -15,5 +15,6 @@ public final class BlockBreakListener implements Listener {
     @EventHandler
     public void onBlockBreak(BlockBreakEvent event) {
         registry.incrementBlocksBroken(event.getBlock().getType());
+        registry.incrementBlocksBroken(event.getBlock().getType(), event.getPlayer().getName());
     }
 }

src/main/java/com/prometheus/spigot/listeners/ChatListener.java

@@ -1,20 +1,20 @@
 package com.prometheus.spigot.listeners;
 
 import com.prometheus.spigot.metrics.MetricsRegistry;
-import io.papermc.paper.event.player.AsyncChatEvent;
 import org.bukkit.event.EventHandler;
 import org.bukkit.event.EventPriority;
 import org.bukkit.event.Listener;
+import org.bukkit.event.player.AsyncPlayerChatEvent;
 
-public final class ChatMessageListener implements Listener {
+public final class ChatListener implements Listener {
     private final MetricsRegistry registry;
 
-    public ChatMessageListener(MetricsRegistry registry) {
+    public ChatListener(MetricsRegistry registry) {
         this.registry = registry;
     }
 
     @EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
-    public void onChat(AsyncChatEvent event) {
+    public void onChat(AsyncPlayerChatEvent event) {
         registry.incrementChatMessages();
     }
 }

src/main/java/com/prometheus/spigot/listeners/MoveListener.java

@@ -20,6 +20,7 @@ public final class MoveListener implements Listener {
             return;
         }
         registry.incrementPlayerMovements();
+        registry.incrementPlayerMovements(event.getPlayer().getName());
     }
 
     private boolean hasChangedBlock(PlayerMoveEvent event) {

src/main/java/com/prometheus/spigot/metrics/MetricsRegistry.java

@@ -46,12 +46,14 @@ public final class MetricsRegistry {
     private final LongAdder pluginDisables = new LongAdder();
     private final ConcurrentHashMap<String, LongAdder> blocksPlacedByMaterial = new ConcurrentHashMap<>();
     private final ConcurrentHashMap<String, LongAdder> blocksBrokenByMaterial = new ConcurrentHashMap<>();
+    private final ConcurrentHashMap<LabelPair, LongAdder> blocksBrokenByPlayerMaterial = new ConcurrentHashMap<>();
     private final ConcurrentHashMap<String, LongAdder> deathsByCause = new ConcurrentHashMap<>();
     private final ConcurrentHashMap<String, LongAdder> loginFailuresByReason = new ConcurrentHashMap<>();
     private final ConcurrentHashMap<String, LongAdder> commandsBlocked = new ConcurrentHashMap<>();
     private final ConcurrentHashMap<LabelPair, LongAdder> commandsExecuted = new ConcurrentHashMap<>();
     private final ConcurrentHashMap<String, LongAdder> itemsCraftedByMaterial = new ConcurrentHashMap<>();
     private final ConcurrentHashMap<LabelPair, LongAdder> entityKills = new ConcurrentHashMap<>();
+    private final ConcurrentHashMap<String, LongAdder> playerMovementsByPlayer = new ConcurrentHashMap<>();
 
     public MetricsRegistry(Server server, boolean enableJvm, boolean enableProcess) {
         this.server = server;
@@ -72,6 +74,10 @@ public final class MetricsRegistry {
         playerMovements.increment();
     }
 
+    public void incrementPlayerMovements(String player) {
+        incrementLabeledCounter(playerMovementsByPlayer, player);
+    }
+
     public void incrementPlayerJoins() {
         playerJoins.increment();
     }
@@ -88,6 +94,14 @@ public final class MetricsRegistry {
         incrementLabeledCounter(blocksBrokenByMaterial, material.name());
     }
 
+    public void incrementBlocksBroken(Material material, String player) {
+        String normalizedMaterial = normalizeLabel(material.name());
+        String normalizedPlayer = normalizeLabel(player);
+        blocksBrokenByPlayerMaterial
+            .computeIfAbsent(new LabelPair(normalizedPlayer, normalizedMaterial), key -> new LongAdder())
+            .increment();
+    }
+
     public void incrementBlocksPlaced(Material material) {
         incrementLabeledCounter(blocksPlacedByMaterial, material.name());
     }
@@ -185,6 +199,8 @@ public final class MetricsRegistry {
         appendCounter(builder, "spigot_plugin_disable_total", "Total plugin disable events", pluginDisables.sum());
 
         appendLabeledCounterAdder(builder, "spigot_blocks_broken_total", "Blocks broken by material", "material", blocksBrokenByMaterial);
+        appendLabeledCounterAdder(builder, "spigot_blocks_broken_by_player_total", "Blocks broken by player and material", "player",
+            "material", blocksBrokenByPlayerMaterial);
         appendLabeledCounterAdder(builder, "spigot_blocks_placed_total", "Blocks placed by material", "material", blocksPlacedByMaterial);
         appendLabeledCounterAdder(builder, "spigot_player_deaths_total", "Player deaths by cause", "cause", deathsByCause);
         appendLabeledCounterAdder(builder, "spigot_player_logins_failed_total", "Failed player logins by reason", "reason", loginFailuresByReason);
@@ -192,6 +208,8 @@ public final class MetricsRegistry {
         appendLabeledCounterAdder(builder, "spigot_commands_executed_total", "Commands executed by source", "command", "source", commandsExecuted);
         appendLabeledCounterAdder(builder, "spigot_items_crafted_total", "Items crafted by material", "material", itemsCraftedByMaterial);
         appendLabeledCounterAdder(builder, "spigot_entities_killed_total", "Entities killed by player", "entity", "killer", entityKills);
+        appendLabeledCounterAdder(builder, "spigot_player_movements_by_player_total", "Player movements by player", "player",
+            playerMovementsByPlayer);
 
         appendGauge(builder, "spigot_players_online", "Online player count", server.getOnlinePlayers().size());
         appendGauge(builder, "spigot_players_max", "Max player slots", server.getMaxPlayers());