feat(events): audit bound book volume navigation
Release / release (push) Failing after 7m17s

This commit is contained in:
dmg committed 2026-09-25 10:44:46 -04:00
1 parent 3f104cb0e2
commit 2cc053e6ff
3 files changed
+98 -11

No files matched your search

@@ -232,6 +232,52 @@ class CharacterBookNativeTest {
}
}
@Test void previousVolumeReturnsToOverviewWithoutInventingAnotherBookOpen() throws Exception {
try (var f = new FantasyStickLifecycleNativeTest.Fixture(data)) {
f.plugin.setEnabled(true);
var actor = new FantasyStickLifecycleNativeTest.Actor(data);
f.players.put(actor.core.id, actor.player); f.activate(actor);
var old = actor.core.record;
var stats = new java.util.EnumMap<games.dmg.fantasystick.progression.Stat, java.math.BigInteger>(games.dmg.fantasystick.progression.Stat.class);
stats.putAll(old.stats()); stats.put(games.dmg.fantasystick.progression.Stat.STR,
new java.math.BigInteger("1234567890".repeat(4000)));
var saved = new games.dmg.fantasystick.persistence.CharacterRecord(old.id(), old.name(),
old.revision().add(java.math.BigInteger.ONE), stats, old.level(), old.experience(),
java.math.BigInteger.ZERO, old.health(), old.learned(), old.loadout(), old.cooldowns(), false, null, null);
new games.dmg.fantasystick.persistence.YamlCharacterRepository(data).replace(saved, old.revision());
click(f, actor); drainReads(f); runQueued(f);
var next = PartyBookNativeTest.button(actor, "[Next pages]");
PartyBookNativeTest.click(f, actor, next); drainReads(f); runQueued(f);
assertTrue(actor.books.size() >= 2);
var previous = PartyBookNativeTest.button(actor, "[Previous pages]");
PartyBookNativeTest.click(f, actor, previous); drainReads(f); runQueued(f);
assertEquals(3, actor.books.size());
PartyBookNativeTest.click(f, actor, previous);
assertEquals(3, actor.books.size(), "Replayed nonce cannot reopen a volume");
}
var records = new java.util.ArrayList<com.google.gson.JsonObject>();
try (var files = Files.walk(data.resolve("events"))) {
for (var path : files.filter(p -> p.getFileName().toString().endsWith(".jsonl")).toList())
for (var line : Files.readAllLines(path))
if (!line.isBlank()) records.add(com.google.gson.JsonParser.parseString(line).getAsJsonObject());
}
var opened = records.stream().filter(e -> e.get("type").getAsString().endsWith("character_book.opened"))
.map(e -> e.get("id").getAsString()).distinct().toList();
assertEquals(1, opened.size());
var navigations = records.stream().filter(e -> e.get("type").getAsString().endsWith("character_book.navigated"))
.collect(java.util.stream.Collectors.toMap(e -> e.get("id").getAsString(), e -> e,
(first, duplicate) -> first, java.util.LinkedHashMap::new));
assertEquals(2, navigations.size());
var previous = navigations.values().stream().map(e -> e.getAsJsonObject("data"))
.filter(d -> d.get("volume_direction").getAsString().equals("previous")).findFirst().orElseThrow();
assertEquals("30", previous.get("source_volume_start").getAsString());
assertEquals("0", previous.get("destination_volume_start").getAsString());
assertEquals("overview", previous.get("destination_section").getAsString());
assertTrue(records.stream().anyMatch(e -> e.get("type").getAsString().endsWith("action.resolved")
&& e.getAsJsonObject("data").has("reason")
&& e.getAsJsonObject("data").get("reason").getAsString().equals("stale_or_forged_payload")));
}
@Test void largeRecordsRemainCompleteThroughBoundedSingleUseNavigation() throws Exception {
int expectedNavigations;
try (var f = new FantasyStickLifecycleNativeTest.Fixture(data)) {
@@ -279,6 +325,16 @@ class CharacterBookNativeTest {
assertArrayEquals(bytes, Files.readAllBytes(data.resolve("characters").resolve(saved.id() + ".yml")));
}
var events=new java.util.ArrayList<com.google.gson.JsonObject>();try(var files=Files.walk(data.resolve("events"))){for(var file:files.filter(path->path.getFileName().toString().endsWith(".jsonl")).toList())for(var line:Files.readAllLines(file))if(!line.isBlank())events.add(com.google.gson.JsonParser.parseString(line).getAsJsonObject());}assertEquals(expectedNavigations,events.stream().filter(event->event.get("type").getAsString().endsWith("character_book.navigated")).count());assertEquals(expectedNavigations,events.stream().filter(event->event.get("type").getAsString().endsWith("character_book.navigated")&&event.getAsJsonObject("data").get("native_open").getAsString().equals("acknowledged")&&event.getAsJsonObject("data").get("offset").getAsInt()>0).count());
var navigation=events.stream().filter(event->event.get("type").getAsString().endsWith("character_book.navigated"))
.findFirst().orElseThrow().getAsJsonObject("data");
assertEquals("0",navigation.get("source_volume_start").getAsString());
assertEquals("30",navigation.get("destination_volume_start").getAsString());
assertEquals("next",navigation.get("volume_direction").getAsString());
assertTrue(navigation.get("source_navigation_page").getAsInt()>0);
assertEquals("1",navigation.get("destination_page").getAsString());
assertEquals("volume_start",navigation.get("destination_section").getAsString());
assertFalse(navigation.has("ability_id"));assertFalse(navigation.has("passive_id"));
assertTrue(navigation.has("location"));
}
@Test void acknowledgedRenameTransferAndReloadInspectTheCurrentRecordWithoutCarryingTheFormerHoldersView() throws Exception {