feat(admin): inspect saved characters
Release / release (push) Failing after 6m1s

This commit is contained in:
dmg committed 2026-09-23 12:50:00 -04:00
1 parent 86f248d80c
commit 7b588e08d2
11 files changed
+555 -22

No files matched your search

@@ -275,8 +275,8 @@ class AdminCharacterBookNativeTest {
assertEquals(java.util.List.of("character", "config"),
fixture.command.tabComplete(admin.player, "fantasystick", new String[]{"c"}));
assertEquals(java.util.List.of("view"),
fixture.command.tabComplete(admin.player, "fantasystick", new String[]{"character", ""}));
assertEquals(java.util.List.of("find", "show", "view"),
fixture.command.tabComplete(admin.player, "fstickadmin", new String[]{"character", ""}));
assertEquals(java.util.List.of("ActiveTarget"),
fixture.command.tabComplete(admin.player, "fantasystick", new String[]{"character", "view", ""}));
assertEquals(java.util.List.of("ActiveTarget"),
@@ -293,8 +293,8 @@ class AdminCharacterBookNativeTest {
admin.allowed = true;
var console = new EquipmentAdminCommandNativeTest.Sender();
assertTrue(fixture.command.tabComplete(console.port, "fantasystick",
new String[]{"character", ""}).isEmpty());
assertEquals(java.util.List.of("find"), fixture.command.tabComplete(console.port, "fstickadmin",
new String[]{"character", ""}));
fixture.command.execute(console.port, "fantasystick",
new String[]{"character", "view", "ActiveTarget"});
assertTrue(console.messages.getLast().contains("in-game administrator"));
@@ -34,6 +34,7 @@ class DefeatHealthDeliveryNativeTest {
if (a.nativePlayer.queuedHealthUpdatePacket != null) sent.add(a.nativePlayer.queuedHealthUpdatePacket);
a.nativePlayer.queueHealthUpdatePacket = false;
PartyLifecycleNativeTest.directory(f).defeat(java.util.UUID.randomUUID()).join();
f.awaitCharacterAndReceipt(a);
PartyBookNativeTest.drain(f);
assertTrue(death.isCancelled());
assertEquals(a.maximumHealth.getValue(), a.player.getHealth());
@@ -0,0 +1,208 @@
package games.dmg.fantasystick;
import static org.junit.jupiter.api.Assertions.*;
import java.nio.file.Path;
import java.util.UUID;
import java.util.concurrent.TimeUnit;
import net.minecraft.network.chat.Component;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
/** Registered saved-character lookup and exact-UUID read-only inspection. */
class SavedCharacterAdminNativeTest {
@TempDir Path data;
@BeforeAll static void bootstrap() throws Exception { NativeRuntime.bootstrap(); }
@Test void findsInactiveSavedCharactersThenShowsExactSavedStateWithoutMutation() throws Exception {
try (var fixture = new FantasyStickLifecycleNativeTest.Fixture(data)) {
fixture.plugin.setEnabled(true);
var administrator = new FantasyStickLifecycleNativeTest.Actor(data);
administrator.accountName = "Admin";
fixture.players.put(administrator.core.id, administrator.player);
var first = new FantasyStickLifecycleNativeTest.Actor(data);
var second = new FantasyStickLifecycleNativeTest.Actor(data);
var storage = characters(fixture);
var renamedFirst = storage.renameCharacter(first.core.record.id(), "Écho Scout").get(5, TimeUnit.SECONDS).orElseThrow();
storage.renameCharacter(second.core.record.id(), "Echo Keeper").get(5, TimeUnit.SECONDS).orElseThrow();
byte[] before = java.nio.file.Files.readAllBytes(data.resolve("characters").resolve(renamedFirst.id() + ".yml"));
assertTrue(fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "find", "echo"}));
drain(fixture);
assertTrue(administrator.messages.stream().anyMatch(message -> message.contains("Echo Keeper")));
assertFalse(administrator.messages.stream().anyMatch(message -> message.contains("Écho Scout")),
"Literal case-insensitive matching does not strip accents");
assertTrue(administrator.messages.stream().anyMatch(message -> message.contains(second.core.record.id().toString())));
assertEquals(java.util.List.of("Echo Keeper"), fixture.adminCommand.tabComplete(administrator.player,
"fstickadmin", new String[]{"character", "find", "ech"}));
assertEquals(java.util.List.of(second.core.record.id().toString()), fixture.adminCommand.tabComplete(
administrator.player, "fstickadmin", new String[]{"character", "show",
second.core.record.id().toString().substring(0, 8)}));
administrator.messages.clear();
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "find", "Écho"});
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "find", "Keeper"});
drain(fixture);
assertFalse(administrator.messages.stream().anyMatch(message -> message.contains("Écho Scout")),
"A superseded asynchronous search must not publish stale results");
assertTrue(administrator.messages.stream().anyMatch(message -> message.contains("Echo Keeper")));
administrator.messages.clear();
assertTrue(fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "show", renamedFirst.id().toString()}));
drain(fixture);
assertEquals(1, administrator.books.size());
String text = pages(administrator).stream().map(Component::getString)
.collect(java.util.stream.Collectors.joining("\n"));
assertTrue(text.contains("Saved state"), text);
assertTrue(text.contains("Inactive"), text);
String unwrapped = text.replace("\n", "");
assertTrue(unwrapped.contains("Saved health: 10/10"), text);
assertTrue(unwrapped.contains(renamedFirst.id().toString()), text);
assertTrue(text.contains("Écho Scout"), text);
assertArrayEquals(before, java.nio.file.Files.readAllBytes(
data.resolve("characters").resolve(renamedFirst.id() + ".yml")));
}
}
@Test void savedViewUsesSavedRatherThanLiveHealthAndRevalidatesPermissionAndLatestRequest() throws Exception {
try (var fixture = new FantasyStickLifecycleNativeTest.Fixture(data)) {
fixture.plugin.setEnabled(true);
var administrator = new FantasyStickLifecycleNativeTest.Actor(data);
var first = new FantasyStickLifecycleNativeTest.Actor(data);
var second = new FantasyStickLifecycleNativeTest.Actor(data);
administrator.accountName = "Admin";
fixture.players.put(administrator.core.id, administrator.player);
fixture.players.put(first.core.id, first.player);
fixture.players.put(second.core.id, second.player);
fixture.activate(first);
first.core.health = 3;
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "show", first.core.record.id().toString()});
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "show", second.core.record.id().toString()});
drain(fixture);
assertEquals(1, administrator.books.size(), "Only the latest saved-state request may open");
String latest = pages(administrator).stream().map(Component::getString)
.collect(java.util.stream.Collectors.joining("\n")).replace("\n", "");
assertTrue(latest.contains(second.core.record.id().toString()));
assertTrue(latest.contains("Inactive"));
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "show", first.core.record.id().toString()});
characters(fixture).find(UUID.randomUUID()).get(5, TimeUnit.SECONDS);
var response = fixture.tasks.poll();
assertNotNull(response);
administrator.allowed = false;
response.run();
assertEquals(1, administrator.books.size());
assertTrue(administrator.messages.getLast().contains("permission changed"));
administrator.allowed = true;
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "show", first.core.record.id().toString()});
drain(fixture);
String active = pages(administrator).stream().map(Component::getString)
.collect(java.util.stream.Collectors.joining("\n")).replace("\n", "");
assertTrue(active.contains("Active"));
assertTrue(active.contains("Saved health: 10/10"), active);
assertFalse(active.contains("Saved health: 3/10"), active);
}
}
@Test void searchPaginatesDuplicateNamesReportsUnreadableRecordsAndSupportsConsole() throws Exception {
try (var fixture = new FantasyStickLifecycleNativeTest.Fixture(data)) {
fixture.plugin.setEnabled(true);
var administrator = new FantasyStickLifecycleNativeTest.Actor(data);
administrator.accountName = "Admin";
fixture.players.put(administrator.core.id, administrator.player);
var storage = characters(fixture);
var records = new java.util.ArrayList<games.dmg.fantasystick.persistence.CharacterRecord>();
for (int index = 0; index < 10; index++) {
var actor = new FantasyStickLifecycleNativeTest.Actor(data);
records.add(storage.renameCharacter(actor.core.record.id(), "Shared Name")
.get(5, TimeUnit.SECONDS).orElseThrow());
if (index == 0) {
actor.core.inventory.setItemInOffHand(new games.dmg.fantasystick.items.CharacterSheets()
.create(records.getLast()));
fixture.players.put(actor.core.id, actor.player);
fixture.activate(actor);
}
}
var dead = storage.recordDeath(records.get(1).id()).get(5, TimeUnit.SECONDS).orElseThrow();
UUID corrupt = UUID.randomUUID();
java.nio.file.Files.writeString(data.resolve("characters").resolve(corrupt + ".yml"),
"schema-version: malformed\n");
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "find", "shared name"});
drain(fixture);
assertTrue(administrator.messages.contains("Saved character results 1/2 (incomplete: 1 unreadable)"));
assertTrue(administrator.messages.contains("Saved character results 2/2 (incomplete: 1 unreadable)"));
assertEquals(10, administrator.messages.stream().filter(message -> message.contains("Shared Name — ")).count());
assertTrue(administrator.messages.stream().anyMatch(message -> message.contains(" — active")));
assertTrue(administrator.messages.stream().anyMatch(message -> message.contains(dead.id().toString())
&& message.contains(" — dead — inactive")));
assertEquals(10, administrator.messageComponents.stream()
.filter(component -> component.clickEvent() != null && component.clickEvent().action()
== net.kyori.adventure.text.event.ClickEvent.Action.SUGGEST_COMMAND)
.count());
var console = new EquipmentAdminCommandNativeTest.Sender();
fixture.adminCommand.execute(console.port, "fstickadmin",
new String[]{"character", "find", "Shared"});
drain(fixture);
assertTrue(console.messages.stream().anyMatch(message -> message.contains("Saved character results 1/2")));
fixture.adminCommand.execute(console.port, "fstickadmin",
new String[]{"character", "show", records.getFirst().id().toString()});
assertTrue(console.messages.getLast().contains("in-game administrator"));
int opened = administrator.books.size();
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "show", dead.id().toString()});
drain(fixture);
assertEquals(opened + 1, administrator.books.size());
String deadText = pages(administrator).stream().map(Component::getString)
.collect(java.util.stream.Collectors.joining("\n")).replace("\n", "");
assertTrue(deadText.contains("Dead"));
assertTrue(deadText.contains(dead.deathId().toString()));
assertTrue(deadText.contains(dead.diedAt().toString()));
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "show", corrupt.toString()});
drain(fixture);
assertEquals(opened + 1, administrator.books.size());
assertTrue(administrator.messages.getLast().contains("could not be loaded"));
fixture.adminCommand.execute(administrator.player, "fstickadmin",
new String[]{"character", "show", UUID.randomUUID().toString()});
drain(fixture);
assertEquals(opened + 1, administrator.books.size());
assertTrue(administrator.messages.getLast().contains("not found"));
}
}
private static games.dmg.fantasystick.persistence.CharacterStorage characters(
FantasyStickLifecycleNativeTest.Fixture fixture) {
return (games.dmg.fantasystick.persistence.CharacterStorage)
FantasyStickLifecycleNativeTest.Fixture.field(fixture.plugin, "characters");
}
private static void drain(FantasyStickLifecycleNativeTest.Fixture fixture) throws Exception {
characters(fixture).find(UUID.randomUUID()).get(5, TimeUnit.SECONDS);
Runnable callback;
while ((callback = fixture.tasks.poll()) != null) callback.run();
}
private static java.util.List<Component> pages(FantasyStickLifecycleNativeTest.Actor actor) {
var content = org.bukkit.craftbukkit.inventory.CraftItemStack.asNMSCopy(actor.books.getLast())
.get(net.minecraft.core.component.DataComponents.WRITTEN_BOOK_CONTENT);
assertNotNull(content);
return content.pages().stream().map(page -> page.raw()).toList();
}
}